fix(drivers): align and improve connect kernel drivers fillers
#2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
the
kind/test
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/milestone 0.22.0 |
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Contributor
Author
|
/unhold as schema version check is a false positive. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2528 +/- ##
=======================================
Coverage 78.53% 78.53%
=======================================
Files 292 292
Lines 31953 31953
Branches 4642 4642
=======================================
Hits 25094 25094
Misses 6859 6859
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The current bpf and kmod's `connect` fillers implementations extract socket tuple information only if the socket file descriptor is greater than or equal to zero: this does not ensure that the file descriptor is valid and that the kernel has the correct amount of information needed to build the socket tuple. On the other side, the modern probe implementation correctly checks the system call return value on the exit program, but doesn't try hard enough to build the socket tuple, as it does not leverage the sockaddr provided by the user. Align all three implementations, checking the system call return value and leveraging the user-provided sockaddr information to build the socket tuple. Signed-off-by: Leonardo Di Giovanna <[email protected]>
ekoops
force-pushed
the
ekoops/fix-connect
branch
from
425b430 to
bf66bc2
Compare
X64 kernel testing matrix
ARM64 kernel testing matrix
|
gnosek
approved these changes
Jul 4, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8b571ca1d636664239b6369b5711752feea120ba |
jasondellaluce
approved these changes
Jul 4, 2025
Contributor
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind test
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
The current bpf and kmod's
connectfillers implementations extract socket tuple information only if the socket file descriptor is greater than or equal to zero: this does not ensure that the file descriptor is valid and that the kernel has the correct amount of information needed to build the socket tuple.On the other side, the modern probe implementation correctly checks the system call return value on the exit program, but doesn't try hard enough to build the socket tuple, as it does not leverage the sockaddr provided by the user.
This PR aligns all three implementations, checking the system call return value and leveraging the user-provided sockaddr information to build the socket tuple.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: