Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Jun 20, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2427.

It:

  • adds PPME_SYSCALL_PPOLL_E parameters to PPME_SYSCALL_PPOLL_X event definition and aligns all 3 kernel drivers to it
  • adds new rules to scap file converter table to convert events in old scap files to the new layout
  • adds/updates ppoll-related drivers, scap converter and sinsp parser tests to account the new layout.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/milestone 0.22.0

@poiana
Copy link
Contributor

poiana commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (5f249d1) to head (5c96916).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2491      +/-   ##
==========================================
+ Coverage   78.10%   78.11%   +0.01%     
==========================================
  Files         264      265       +1     
  Lines       31308    31331      +23     
  Branches     4645     4645              
==========================================
+ Hits        24452    24475      +23     
  Misses       6856     6856              
Flag Coverage Δ
libsinsp 78.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add `PPME_SYSCALL_PPOLL_E` parameters to `PPME_SYSCALL_PPOLL_X` event
definition and aligns all 3 kernel drivers to it.

Add new rules to scap file converter table to convert events in old
scap files to the new layout.

Add/update ppoll-related drivers, scap converter and sinsp parser
tests to account the new layout.

Signed-off-by: Leonardo Di Giovanna <[email protected]>
@ekoops ekoops force-pushed the ekoops/convert-ppoll branch from 00662e0 to 5c96916 Compare June 20, 2025 13:57
@github-actions
Copy link

github-actions bot commented Jun 20, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@github-actions
Copy link

Perf diff from master - unit tests

     5.56%     +0.61%  [.] sinsp_evt::get_type
    18.80%     -0.58%  [.] sinsp_thread_manager::create_thread_dependencies
     2.60%     +0.39%  [.] gzfile_read
     1.32%     -0.35%  [.] sinsp_evt_filter::sinsp_evt_filter
     5.70%     -0.27%  [.] sinsp_parser::reset
     0.81%     -0.24%  [.] sinsp_evt::get_syscall_return_value
     4.92%     +0.24%  [.] sinsp_thread_manager::find_thread
     1.62%     -0.24%  [.] scap_event_decode_params
     1.27%     -0.23%  [.] libsinsp::sinsp_suppress::process_event
     2.60%     -0.21%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

peak heap memory consumption: -2.15K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 2.92M

Heap diff from master - scap file

peak heap memory consumption: -116B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0291         -0.0290           149           145           149           145
BM_sinsp_split_median                                          -0.0281         -0.0281           150           145           150           145
BM_sinsp_split_stddev                                          -0.0318         -0.0348             2             2             2             2
BM_sinsp_split_cv                                              -0.0028         -0.0059             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1492         -0.1492            64            55            64            55
BM_sinsp_concatenate_paths_relative_path_median                -0.1593         -0.1593            64            54            64            54
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1532         +0.1551             1             2             1             2
BM_sinsp_concatenate_paths_relative_path_cv                    +0.3554         +0.3576             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0312         -0.0312            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0318         -0.0318            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +2.3085         +2.3230             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +2.4151         +2.4301             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0630         -0.0630            61            57            61            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.0549         -0.0549            61            58            61            58
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4505         -0.4524             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4135         -0.4156             0             0             0             0

@poiana
Copy link
Contributor

poiana commented Jun 20, 2025

LGTM label has been added.

DetailsGit tree hash: c3f0f8301973d753fd8f66c1f714781641cd9efc

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 20, 2025
@poiana poiana merged commit e81b13a into master Jun 20, 2025
69 of 71 checks passed
@poiana poiana deleted the ekoops/convert-ppoll branch June 20, 2025 16:16
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 20, 2025
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants