Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Jun 18, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2427.

It adds PPME_SYSCALL_MMAP2_E params to PPME_SYSCALL_MMAP2_X event definition and aligns all 3 kernel drivers to it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.22.0

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@ekoops ekoops force-pushed the ekoops/convert-mmap2 branch from 232fdae to 7bddd96 Compare June 18, 2025 14:46
@github-actions
Copy link

Perf diff from master - unit tests

     7.41%     -0.55%  [.] sinsp::next
     5.83%     -0.45%  [.] sinsp_evt::get_type
     5.47%     -0.37%  [.] sinsp_parser::reset
     2.06%     -0.27%  [.] can_query_os_for_thread_info
     2.75%     +0.25%  [.] gzfile_read
     0.42%     +0.25%  [.] sinsp_fdtable::find
     5.00%     +0.21%  [.] sinsp_thread_manager::find_thread
     1.66%     -0.19%  [.] next
     1.37%     +0.18%  [.] user_group_updater::~user_group_updater
     0.70%     +0.16%  [.] sinsp_evt::get_ts

Heap diff from master - unit tests

peak heap memory consumption: -714B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -124B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0176         +0.0176           145           147           145           147
BM_sinsp_split_median                                          +0.0198         +0.0198           144           147           144           147
BM_sinsp_split_stddev                                          -0.0846         -0.0849             1             1             1             1
BM_sinsp_split_cv                                              -0.1005         -0.1008             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1023         +0.1023            55            61            55            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0717         +0.0717            55            59            55            59
BM_sinsp_concatenate_paths_relative_path_stddev                +0.2854         +0.2855             2             2             2             2
BM_sinsp_concatenate_paths_relative_path_cv                    +0.1661         +0.1663             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0062         -0.0062            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0037         -0.0037            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5313         -0.5340             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5283         -0.5311             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.2199         +0.2199            54            66            54            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.2465         +0.2464            54            67            54            67
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.8565         +0.8567             2             3             2             3
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.5219         +0.5220             0             0             0             0

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (3c0a93c) to head (7bddd96).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
+ Coverage   78.00%   78.02%   +0.01%     
==========================================
  Files         256      257       +1     
  Lines       31174    31198      +24     
  Branches     4645     4645              
==========================================
+ Hits        24318    24342      +24     
  Misses       6856     6856              
Flag Coverage Δ
libsinsp 78.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana
Copy link
Contributor

poiana commented Jun 18, 2025

LGTM label has been added.

DetailsGit tree hash: 5cae68cc62270f325a7837909d579ad2587c7df7

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 18, 2025
@poiana poiana merged commit 316ffbe into master Jun 18, 2025
79 of 82 checks passed
@poiana poiana deleted the ekoops/convert-mmap2 branch June 18, 2025 15:58
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 18, 2025
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants