Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Jun 5, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2427.

It adds enter events parameters to PPM_EPOLLWAIT_X event definition and aligns all three kernel drivers to the new definition.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ekoops
Copy link
Contributor Author

ekoops commented Jun 5, 2025

@ekoops
Copy link
Contributor Author

ekoops commented Jun 5, 2025

/milestone 0.22.0

@poiana poiana added this to the 0.22.0 milestone Jun 5, 2025
@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Perf diff from master - unit tests

    29.05%     -1.10%  [.] sinsp_thread_manager::create_thread_dependencies
     1.28%     -0.95%  [.] scap_file_test::assert_event_presence
     1.53%     -0.59%  [.] sinsp::fetch_next_event
     6.69%     -0.45%  [.] sinsp::next
     2.10%     +0.41%  [.] gzfile_read
     4.68%     +0.39%  [.] sinsp_evt::get_type
     5.39%     +0.33%  [.] sinsp_parser::reset
     1.33%     +0.30%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.11%     +0.25%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.76%     +0.23%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: -1.14K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -114B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0089         +0.0089           147           148           147           148
BM_sinsp_split_median                                          +0.0101         +0.0101           147           148           147           148
BM_sinsp_split_stddev                                          -0.2812         -0.2817             1             1             1             1
BM_sinsp_split_cv                                              -0.2875         -0.2881             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0655         +0.0655            61            65            61            65
BM_sinsp_concatenate_paths_relative_path_median                +0.0744         +0.0744            61            65            61            65
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5394         -0.5394             2             1             2             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5677         -0.5677             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0370         -0.0370            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0353         -0.0353            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8336         -0.8329             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8272         -0.8264             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0152         +0.0152            65            66            65            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.0130         +0.0130            65            66            65            66
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2168         -0.2169             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.2285         -0.2286             0             0             0             0

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (09fc748) to head (8ad4bdb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
+ Coverage   77.72%   77.74%   +0.01%     
==========================================
  Files         241      242       +1     
  Lines       30893    30912      +19     
  Branches     4661     4661              
==========================================
+ Hits        24013    24032      +19     
  Misses       6880     6880              
Flag Coverage Δ
libsinsp 77.74% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
Copy link
Contributor Author

ekoops commented Jun 5, 2025

arm64:

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

amd64:

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Good to go!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 5, 2025

LGTM label has been added.

DetailsGit tree hash: 3e1b7f52f4ca6118482a88352b1361cdf28e302d

@poiana
Copy link
Contributor

poiana commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Jun 5, 2025
@poiana poiana merged commit 067f3d4 into falcosecurity:master Jun 5, 2025
57 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Jun 5, 2025
@ekoops ekoops deleted the ekoops/convert-epoll-wait branch June 6, 2025 11:04
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants