Fix mod version compatibility checking for major version differences #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #517 where the auto mod updater was downloading incorrect mod versions after updating to Space Age (Factorio 2.0). The mod updater would download 1.x versions of mods instead of the compatible 2.x versions.
Problem
The version checking logic in
check_game_version()
was incorrectly implemented:Solution
check_game_version()
to properly check if the current game version satisfies the mod's minimum required versioncheck_dependency_version()
that were using$FACTORIO_VERSION
instead of$mod_version
Testing
The fix has been tested with various version combinations:
Related Issues
This also addresses issue #468 by ensuring mods requiring newer Factorio versions than currently installed are properly skipped.
Fixes #517
Fixes #468