Skip to content

Added Blackwell Support #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

LagPixelLOL
Copy link

Added Blackwell support, updated FA3 checks to only allow SM90.

Fixed #1251, and improved #1254.

@facebook-github-bot
Copy link
Contributor

Hi @LagPixelLOL!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@danthe3rd
Copy link
Contributor

Thanks! We're working on updating FA3 on some internal PRs, so I'd like to merge those before adding Blackwell.
We're also going to deprecate V100 following what PyTorch did

@johnnynunez
Copy link

Added Blackwell support, updated FA3 checks to only allow SM90.

Fixed #1251, and improved #1254.

could you add:
8.7 Orin
11.0 Thor
12.1 Spark?

@LagPixelLOL
Copy link
Author

Added Blackwell support, updated FA3 checks to only allow SM90.
Fixed #1251, and improved #1254.

could you add: 8.7 Orin 11.0 Thor 12.1 Spark?

Are you sure they are supported?

@johnnynunez
Copy link

Added Blackwell support, updated FA3 checks to only allow SM90.
Fixed #1251, and improved #1254.

could you add: 8.7 Orin 11.0 Thor 12.1 Spark?

Are you sure they are supported?

8.7 orin is working, and spark 12.1 also. Thor is coming with Cuda 13

@johnnynunez
Copy link

It compiles gh200? I have errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory_efficient_attention fails with half precision tensors, with pre-compiled xformers 0.0.30 on RTX 5090
4 participants