Rework ET Replay Targets #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Ran into errors in D67550787 which I couldn't work out how to solve, so I started over the targets in ET Replay so that adding new functionality would be easier in the future Feel free to suggest improvements, alternatives etc Differential Revision: D72708068
briancoutinho
requested review from
kingchc,
louisfeng,
shengbao-zheng and
sunghlin
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72708068 |
Contributor
|
This pull request has been merged in 42c2b12. |
sanshang-nv
reviewed
Apr 18, 2025
| from et_replay.comm.backend.base_backend import supportedP2pOps | ||
| from et_replay.comm.comms_utils import commsArgs | ||
|
|
||
| from et_replay.execution_trace import ExecutionTrace |
Contributor
There was a problem hiding this comment.
Seems no need to add .execution_trace, as ExecutionTrace class has been exported.
Line 3 in fb81f66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ran into errors in D67550787 which I couldn't work out how to solve, so I started over the targets in ET Replay so that adding new functionality would be easier in the future
Feel free to suggest improvements, alternatives etc
Differential Revision: D72708068