add support to metrics calculation #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
briancoutinho,
kingchc,
louisfeng,
shengbao-zheng and
sunghlin
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
|
@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add support to metrics calculation. 1. Iteration E2E time 2. bandwidth This is the copy of #195 for importing it into Meta. Differential Revision: D68038126 Pulled By: shengfukevin
facebook-github-bot
force-pushed
the
sanshang/calc_metrics
branch
from
7af31e6 to
410aae0
Compare
Contributor
|
@shengfukevin has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68038126 |
sanshang-nv
reviewed
Jan 23, 2025
| and not len(args.output_path) | ||
| ): | ||
| raise ValueError('"--output-path" is not set for profiler trace dumping') | ||
| """ |
Contributor
There was a problem hiding this comment.
Why you comment out this check here?
sanshang-nv
reviewed
Jan 23, 2025
| _torch_profiler = None | ||
|
|
||
|
|
||
| def startProfiler( |
| return False | ||
|
|
||
|
|
||
| def sampleProfiler(stop: bool = False) -> None: |
Contributor
There was a problem hiding this comment.
where to invoke this function with stop=true?
Contributor
|
Hi, @shengfukevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to metrics calculation.
This is the copy of #195 for importing it into Meta.