This repository was archived by the owner on Apr 28, 2023. It is now read-only.
bump isl for merge of C++ bindings #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ bindings from mainline isl do not allow an object to be explicitly assigned a NULL value.
skimo-openhub
force-pushed
the
pr/merge_master
branch
from
1b9289b to
7e344e4
Compare
skimo-openhub
force-pushed
the
pr/merge_master
branch
from
7e344e4 to
5281e66
Compare
skimo-openhub
requested review from
Artix18 and
thetheodor
and removed request for
Artix18
ftynse
reviewed
Aug 15, 2018
| @@ -71,7 +71,9 @@ struct Scop { | |||
| res->parameterValues = scop.parameterValues; | |||
| res->halide = scop.halide; | |||
| res->body = scop.body; | |||
| res->dependences = scop.dependences; | |||
| if (scop.dependences) { | |||
There was a problem hiding this comment.
I'm not sure this is a good idea, see discussion in isl maiilng
|
On Wed, Aug 15, 2018 at 03:14:29AM -0700, ftynse wrote:
ftynse commented on this pull request.
> @@ -71,7 +71,9 @@ struct Scop {
res->parameterValues = scop.parameterValues;
res->halide = scop.halide;
res->body = scop.body;
- res->dependences = scop.dependences;
+ if (scop.dependences) {
I'm not sure this is a good idea, see discussion in isl maiilng
That discussion is about future versions of isl.
That doesn't help with dealing with the current version.
skimo
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/nicolasvasilache/isl/pull/176