This repository was archived by the owner on Apr 28, 2023. It is now read-only.
Update to support upcoming Caffe2 API #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasvasilache
added a commit
that referenced
this pull request
Jul 3, 2018
nicolasvasilache
force-pushed
the
pr/caffe2-update
branch
2 times, most recently
from
f99e476 to
f938693
Compare
Caffe2 API killed the copy constructor so we need to update `GetNamedTensor`. So we use the Caffe2 API to return a new tensor that shares the data with the tensor from the workspace. Tested internally with the latest API.
nicolasvasilache
force-pushed
the
pr/caffe2-update
branch
from
f938693 to
c805194
Compare
Without this, the following error occurs: `TypeError: 'float' object cannot be interpreted as an integer`
added 2 commits
July 6, 2018 08:38
Tested internally
Tested internally
nicolasvasilache
force-pushed
the
pr/caffe2-update
branch
from
efc76a1 to
379a450
Compare
mingzhe09088
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few modifications to sync OSS to fbcode.
min_distance.pyTested internally with the latest API.