This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Fix version of nbconvert, and update ipynb to html script #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Script to parse to ipynb into html for ClassyVision website was broken, as there was no longer a `div` with `id` `notebook-container`. Likely culprit is `nbconvert`, so fixed version in `setup.py` to hopefully prevent breakage in the future. Reviewed By: vreis Differential Revision: D25128504 fbshipit-source-id: d28fb0aef4887a1cfc3eb290f836c4f2f68b3184
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25128504 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
Summary: Pull Request resolved: fairinternal/ClassyVision#88 Pull Request resolved: #662 Script to parse to ipynb into html for ClassyVision website was broken, as there was no longer a `div` with `id` `notebook-container`. Likely culprit is `nbconvert`, so fixed version in `setup.py` to hopefully prevent breakage in the future. Reviewed By: vreis Differential Revision: D25128504 fbshipit-source-id: f636d3f55d6ea0f50bac28f398d26a21ccaf405e
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
Summary: Pull Request resolved: fairinternal/ClassyVision#88 Pull Request resolved: #662 Script to parse to ipynb into html for ClassyVision website was broken, as there was no longer a `div` with `id` `notebook-container`. Likely culprit is `nbconvert`, so fixed version in `setup.py` to hopefully prevent breakage in the future. Reviewed By: vreis Differential Revision: D25128504 (bd5c260) fbshipit-source-id: 52be1720e9f10bf38eec3dbaf7824ccf2c72a5af
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Script to parse to ipynb into html for ClassyVision website was broken, as there was no longer a
divwithidnotebook-container. Likely culprit isnbconvert, so fixed version insetup.pyto hopefully prevent breakage in the future.Reviewed By: vreis
Differential Revision: D25128504