Table scan cleanup #9156
Table scan cleanup #9156
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
|
||
| // Process-wide IO wait time. | ||
| static std::atomic<uint64_t> ioWaitNanos_; | ||
| inline static std::atomic<uint64_t> ioWaitNanos_; |
There was a problem hiding this comment.
Maybe move this into a global variable in cpp file only
There was a problem hiding this comment.
There is a static method that report this which is now only used by test but could be used by production later so keep it here.
There was a problem hiding this comment.
Will the inline here create multiple instances and the value is no longer process-wide?
There was a problem hiding this comment.
It is static so it should be singleton, and used it in many places.
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| preload(connectorSplit); | ||
| } else if ( | ||
| readySplitIndex == -1 && connectorSplit->dataSource->hasValue()) { | ||
| (readySplitIndex == -1) && (connectorSplit->dataSource->hasValue())) { |
There was a problem hiding this comment.
nit: are the additional parentheses necessary? IMO they make it less readable (but that's just an opinion)
|
@xiaoxmeng merged this pull request in 5e07790. |
Summary: Pull Request resolved: facebookincubator#9156 Reviewed By: kevinwilfong Differential Revision: D55086413 Pulled By: xiaoxmeng fbshipit-source-id: 60c557f7635e7eb498e17e46f1a15534d862b8bf
4 participants
No description provided.