Add release callbacks to QueryCtx #15858
Open
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Differential Revision: D89797291
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@shrinidhijoshi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89797291. |
shrinidhijoshi
added a commit
to shrinidhijoshi/velox
that referenced
this pull request
Dec 26, 2025
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Differential Revision: D89797291
shrinidhijoshi
added a commit
to shrinidhijoshi/velox
that referenced
this pull request
Dec 26, 2025
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Differential Revision: D89797291
shrinidhijoshi
added a commit
to shrinidhijoshi/velox
that referenced
this pull request
Dec 26, 2025
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Differential Revision: D89797291
xiaoxmeng
approved these changes
Dec 26, 2025
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@shrinidhijoshi LGTM % minors. Thanks!
| using ReleaseCallback = std::function<void()>; | ||
|
|
||
| ~QueryCtx(); | ||
| void addReleaseCallback(ReleaseCallback callback) { |
Contributor
There was a problem hiding this comment.
Put this ahead of fsTokenProvider
| VELOX_CHECK(!underArbitration_); | ||
| using ReleaseCallback = std::function<void()>; | ||
|
|
||
| ~QueryCtx(); |
shrinidhijoshi
added a commit
to shrinidhijoshi/velox
that referenced
this pull request
Dec 26, 2025
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Reviewed By: xiaoxmeng Differential Revision: D89797291
shrinidhijoshi
added a commit
to shrinidhijoshi/velox
that referenced
this pull request
Dec 26, 2025
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed Reviewed By: xiaoxmeng Differential Revision: D89797291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add ability to provide callbacks to be executed before QueryCtx is destructed
Differential Revision: D89797291