feat: Support ArrayOrMapSubscript in Hive connector #15857
+716
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D88739397
Summary: Add support for the new `ArrayOrMapSubscript` subfield path element. This new element will only be enabled when plan contains it, so existing use cases are not changed. Refactor the code to extract the handling of ARRAY and MAP subfields to their own method for readability, no functional change on existing use cases. Currently the parser only supports `[$]` case, so unit test only has that part. Other cases will be added when the corresponding parsers are implemented. Differential Revision: D89565249
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for the new
ArrayOrMapSubscriptsubfield path element. This new element will only be enabled when plan contains it, so existing use cases are not changed. Refactor the code to extract the handling of ARRAY and MAP subfields to their own method for readability, no functional change on existing use cases.Currently the parser only supports
[$]case, so unit test only has that part. Other cases will be added when the corresponding parsers are implemented.Differential Revision: D89565249