refactor(query-ctx): Add builder pattern and documentation #15853
+242
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adding a builder pattern for constructing QueeryCtx objects. QueryCtx is part of the external API, and adding members to it over time has cluttered the create() and constructor methods. It was pretty inconvenient to add and pass new members to it. Also adding more documentation and removing unnecessary includes and forward declarations. No logic changes. Differential Revision: D89744645
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding a builder pattern for constructing QueryCtx objects. QueryCtx
is part of the external API, and adding members to it over time has cluttered
the create() and constructor methods. It was pretty inconvenient to add and
pass new members to it.
Also adding more documentation and removing unnecessary includes and forward
declarations. No logic changes.
Differential Revision: D89744645