refactor(cudf): Improve debug printing for cudf #15831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
requested review from
bdice,
devavret and
mhaseeb123
as code owners
karthikeyann
added
enhancement
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
| const std::shared_ptr<velox::exec::Expr>& expr, | ||
| int indent = 0) { | ||
| std::cout << std::string(indent, ' ') << expr->name() << std::endl; | ||
| std::cout << std::string(indent, ' ') << expr->name() << "(" |
Collaborator
There was a problem hiding this comment.
Why not use this with default argument recursive = true
/// @param recursive If true, the output includes input expressions and all
/// their inputs recursively.
virtual std::string toString(bool recursive = true) const;
| << oper->toString().c_str() | ||
| << ", keepOperator = " << keepOperator | ||
| << ", replaceOp.size() = " << replaceOp.size() << "\n"; | ||
| << ", replaceOp.size() = " << replaceOp.size() << ", "; |
Collaborator
There was a problem hiding this comment.
Why the line ends with , ?
| } else if (!condition) { | ||
| LOG(WARNING) | ||
| << "Replacement with cuDF operator failed. Falling back to CPU execution"; | ||
| LOG(WARNING) << "Replacement Failed Operator: " << oper->toString() |
Collaborator
There was a problem hiding this comment.
No need to add << std::endl in the end, LOG(WARNING) logs a line
| } | ||
| } else { | ||
| if (CudfConfig::getInstance().debugEnabled) { | ||
| LOG(INFO) << cudf::ast::expression_to_string(cudfTree_.back()) |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| /* |
Collaborator
There was a problem hiding this comment.
Remove some duplicated license declaration
| @@ -0,0 +1,475 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
Do we have the specification for the file name? I notice some is .hpp while Velox is always .h, and some is .cu
| /** | ||
| * @brief Get the string representation of a cudf::type_id | ||
| */ | ||
| inline std::string type_id_to_string(cudf::type_id id) { |
Collaborator
There was a problem hiding this comment.
Does the file copy from somewhere? If yes, please add the link and describe why you need to copy it instead linking it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug prints during execution of cudf driver adapter is improved in this PR