misc: Fix ReaderTest.projectColumnsMutation #15830
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
@yfeldblum has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89581389. |
meta-cla
bot
added
the
CLA Signed
Yuhta
approved these changes
Dec 19, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2025
Summary: The test currently hardcodes exact expected results of random algorithms rather than asserting expected properties of the results. This blocks changing the RNG. Switch to a property-based test to unblock evolution of the RNG. Reviewed By: Yuhta Differential Revision: D89581389
facebook-github-bot
force-pushed
the
export-D89581389
branch
from
d1e5d79 to
c05fa0c
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Summary: The test currently hardcodes exact expected results of random algorithms rather than asserting expected properties of the results. This blocks changing the RNG. Switch to a property-based test to unblock evolution of the RNG. Reviewed By: Yuhta Differential Revision: D89581389
facebook-github-bot
force-pushed
the
export-D89581389
branch
from
c05fa0c to
716a9ca
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
Summary: The test currently hardcodes exact expected results of random algorithms rather than asserting expected properties of the results. This blocks changing the RNG. Switch to a property-based test to unblock evolution of the RNG. Reviewed By: Yuhta Differential Revision: D89581389
facebook-github-bot
force-pushed
the
export-D89581389
branch
from
716a9ca to
45d249c
Compare
Summary: The test currently hardcodes exact expected results of random algorithms rather than asserting expected properties of the results. This blocks changing the RNG. Switch to a property-based test to unblock evolution of the RNG. Reviewed By: Yuhta Differential Revision: D89581389
facebook-github-bot
force-pushed
the
export-D89581389
branch
from
45d249c to
5d05fb4
Compare
|
This pull request has been merged in b325a22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The test currently hardcodes exact expected results of random algorithms rather than asserting expected properties of the results. This blocks changing the RNG. Switch to a property-based test to unblock evolution of the RNG.
Differential Revision: D89581389