feat: Fix casting of invalid row positions to Json #15828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
…#15828) Summary: When casting nested ROW types to JSON, castToJsonFromRow would process all child elements including those at null positions. Since Velox vectors can have invalid data at null positions (e.g., Timestamp with nanos > 1 billion), this could cause crashes during JSON serialization. The fix is to filter out null rows from each child's SelectivityVector before creating AsJson. When all rows are null for a child, store std::nullopt and output "null" directly during rendering. This prevents accessing potentially invalid underlying data at null positions. Differential Revision: D89577815
kgpai
force-pushed
the
export-D89577815
branch
from
8f192be to
084c33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When casting nested ROW types to JSON, castToJsonFromRow would process all child elements including those at null positions. Since Velox vectors can have invalid data at null positions (e.g., Timestamp with nanos > 1 billion), this could cause crashes during JSON serialization.
The fix is to filter out null rows from each child's SelectivityVector before creating AsJson. When all rows are null for a child, store std::nullopt and output "null" directly during rendering. This prevents accessing potentially invalid underlying data at null positions.
Differential Revision: D89577815