feat: Add IPAddress support to PrestoQueryRunner for Velox fuzzers #15821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enable IPAddress type testing across all Velox fuzzers that use PrestoQueryRunner, including JoinFuzzer, AggregationFuzzer, and ExpressionFuzzer etc. Previously, IPAddress was excluded from fuzzer testing because PrestoQueryRunner didn't register it as a supported scalar type and explicitly blocked it in signature validation. This change adds IPAddress to the scalar types list and provides a VARCHAR-based intermediate type transform for result comparison against Presto. Differential Revision: D89539377
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@pratikpugalia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89539377. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable IPAddress type testing across all Velox fuzzers that use PrestoQueryRunner, including JoinFuzzer, AggregationFuzzer, and ExpressionFuzzer etc.
Previously, IPAddress was excluded from fuzzer testing because PrestoQueryRunner didn't register it as a supported scalar type and explicitly blocked it in signature validation. This change adds IPAddress to the scalar types list and provides a VARCHAR-based intermediate type transform for result comparison against Presto.
Differential Revision: D89539377