feat: Add strpos and contains for varbinary #15809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
@laurencer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89479354. |
meta-cla
bot
added
the
CLA Signed
laurencer
force-pushed
the
export-D89479354
branch
from
14f33eb to
893b690
Compare
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 19, 2025
Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Differential Revision: D89479354
laurencer
force-pushed
the
export-D89479354
branch
from
893b690 to
8844814
Compare
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 19, 2025
…or#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Differential Revision: D89479354
laurencer
changed the title
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 20, 2025
…ookincubator#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Differential Revision: D89479354
laurencer
force-pushed
the
export-D89479354
branch
from
8844814 to
3959617
Compare
laurencer
force-pushed
the
export-D89479354
branch
from
3959617 to
c219946
Compare
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 20, 2025
…ookincubator#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Differential Revision: D89479354
laurencer
force-pushed
the
export-D89479354
branch
from
c219946 to
ef82578
Compare
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 22, 2025
…ookincubator#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Differential Revision: D89479354
laurencer
changed the title
laurencer
added a commit
to laurencer/velox
that referenced
this pull request
Dec 22, 2025
…ookincubator#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Reviewed By: kaikalur Differential Revision: D89479354
laurencer
force-pushed
the
export-D89479354
branch
from
ef82578 to
53fc9e1
Compare
…ookincubator#15809) Summary: Adds `strpos`, `strrpos` and `contains` for varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation). Reviewed By: kaikalur Differential Revision: D89479354
laurencer
force-pushed
the
export-D89479354
branch
from
53fc9e1 to
b4a5f1c
Compare
laurencer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds
strpos,strrposandcontainsfor varbinary columns which will allow for efficient string searching in encoded text data where we don't want to pay the charset decoding price (i.e. we don't have to convert the column to utf-8 and just do byte matches as an approximation).Differential Revision: D89479354