Skip to content

docs: Fix CompareFlags documentation #15706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pramodsatya wants to merge 1 commit into from
Closed

docs: Fix CompareFlags documentation #15706

pramodsatya wants to merge 1 commit into from

Conversation

@pramodsatya
Copy link
Collaborator

@pramodsatya pramodsatya commented Dec 5, 2025

Fixes typo in CompareFlags documentation. Enables accurate Copilot code reviews.

@netlify
Copy link

netlify bot commented Dec 5, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit dde3fa7
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/6937ef1ad1941c00086006aa

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2025
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a documentation typo in the CompareFlags class where an example incorrectly stated that (1, 1) = (1, 1) would result in "indeterminate" when it should result in "true". The fix aligns the documentation with the actual comparison logic for row types under Presto semantics (kNullAsIndeterminate mode).

  • Corrects the expected result for a non-null row comparison example from "indeterminate" to "true"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mbasmanova
mbasmanova approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mbasmanova mbasmanova changed the title docs: Fix compare flags documentation docs: Fix CompareFlags documentation Dec 9, 2025
@mbasmanova mbasmanova added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Dec 9, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 18, 2025

@kKPulla has imported this pull request. If you are a Meta employee, you can view this in D89483371.

@meta-codesync meta-codesync bot closed this in 59178cd Dec 19, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 19, 2025

@kKPulla merged this pull request in 59178cd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mbasmanova mbasmanova mbasmanova approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak

@czentgr czentgr Awaiting requested review from czentgr

@aditi-pandit aditi-pandit Awaiting requested review from aditi-pandit

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pramodsatya @mbasmanova @facebook-github-bot