test: Disable O_DIRECT in cache fuzzer #12154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
approved these changes
Jan 23, 2025
Contributor
kagamiori
left a comment
kagamiori
left a comment
There was a problem hiding this comment.
Thank you for the quick fix!
kagamiori
reviewed
Jan 23, 2025
| // O_DIRECT requires I/O size needs to be the same as a disk file block size | ||
| // which is not handled in SSD cache. Misalignment can lead to EINVAL in some | ||
| // filesystem and kernel version. | ||
| FLAGS_ssd_odirect = false; |
Contributor
There was a problem hiding this comment.
Can we add a "// TODO: add this support if needed later."?
zacw7
force-pushed
the
export-D68562695
branch
from
e4765b6 to
32a8f5f
Compare
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 23, 2025
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: kagamiori, yuandagits Differential Revision: D68562695
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
xiaoxmeng
approved these changes
Jan 24, 2025
| region_.length, | ||
| region.offset - region_.offset, | ||
| fileIds().string(fileNum_)); | ||
| // LOG(ERROR) << "IOERR: Failed SSD loadSync " << entry.toString() << ' ' |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 24, 2025
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
force-pushed
the
export-D68562695
branch
from
32a8f5f to
e364076
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 24, 2025
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
force-pushed
the
export-D68562695
branch
from
e364076 to
b5ceef7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 27, 2025
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
force-pushed
the
export-D68562695
branch
from
b5ceef7 to
9a3af71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 27, 2025
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
force-pushed
the
export-D68562695
branch
from
9a3af71 to
0f0a737
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
Summary: O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 28, 2025
Summary: Pull Request resolved: facebookincubator#12154 O_DIRECT requires I/O size needs to be the same as a disk file block size which is not handled in SSD cache. Misalignment can lead to EINVAL in some filesystem and kernel version. Reviewed By: xiaoxmeng, kagamiori, yuandagits Differential Revision: D68562695
zacw7
force-pushed
the
export-D68562695
branch
2 times, most recently
from
17308e9 to
5095b2b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68562695 |
Contributor
|
This pull request has been merged in 9999ae0. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
O_DIRECT requires I/O size needs to be the same as a disk file block size
which is not handled in SSD cache. Misalignment can lead to EINVAL in some
filesystem and kernel version.
Differential Revision: D68562695