Fix Race Condition During Stats Aggregation During Parallel Encoding with Chunking #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88445993. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 5, 2025
…with Chunking (facebookincubator#357) Summary: This diff addresses a data race condition introduced by a recent refactoring in the handling of column stats objects for individual streams. Previously, the creation and access of column stats objects for individual streams were moved inside a barrier as [part of a refactor.](https://www.internalfb.com/diff/D88053111?entry_point=19) However, that change inadvertently introduced a data race, as multiple threads could concurrently create or access these objects without proper synchronization. This issue was detected by our TSAN (ThreadSanitizer) tests, which reported failures due to the race condition. This diff ensures that the creation and access of column stats objects are properly synchronized within the barrier, eliminating the data race. As a result, TSAN tests now pass, confirming that the concurrency issue has been resolved.x Differential Revision: D88445993
macvincent
force-pushed
the
export-D88445993
branch
from
a552bbd to
911d694
Compare
…with Chunking (facebookincubator#357) Summary: This diff addresses a data race condition introduced by a recent refactoring in the handling of column stats objects for individual streams. Previously, the creation and access of column stats objects for individual streams were moved inside a barrier as [part of a refactor.](https://www.internalfb.com/diff/D88053111?entry_point=19) However, that change inadvertently introduced a data race, as multiple threads could concurrently create or access these objects without proper synchronization. This issue was detected by our TSAN (ThreadSanitizer) tests, which reported failures due to the race condition. This diff ensures that the creation and access of column stats objects are properly synchronized within the barrier, eliminating the data race. As a result, TSAN tests now pass, confirming that the concurrency issue has been resolved.x Differential Revision: D88445993
macvincent
force-pushed
the
export-D88445993
branch
from
911d694 to
700bae6
Compare
xiaoxmeng
approved these changes
Dec 5, 2025
|
This pull request has been merged in 6426223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff addresses a data race condition introduced by a recent refactoring in the handling of column stats objects for individual streams. Previously, the creation and access of column stats objects for individual streams were moved inside a barrier as part of a refactor. However, that change inadvertently introduced a data race, as multiple threads could concurrently create or access these objects without proper synchronization. This issue was detected by our TSAN (ThreadSanitizer) tests, which reported failures due to the race condition. This diff ensures that the creation and access of column stats objects are properly synchronized within the barrier, eliminating the data race. As a result, TSAN tests now pass, confirming that the concurrency issue has been resolved.x
Differential Revision: D88445993