(fix): Fix Flakiness in Writer Unit Test #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D87964917 made a change to a CMakeLists.txt file that broke OSS builds. This diff fixes that. Differential Revision: D88117968
…#339) Summary: The test util used to calculate encoding sizes in NimbleDump and VeloxWriter tests only includes the size of the nulls bits for nullable encoded data. This is different from how sizes are nullable content stream sizes are calculated in the rest of our code base and introduced flakiness to a VeloxWriter test. This diff fixes that. Differential Revision: D88113894
Summary: In `VeloxWriterTests.fuzzComplex` random min and max stream chunk size values are selected. However, flaky errors may occur when these values are close. For instance in this case: ``` buck run mode/opt dwio/nimble/velox/tests/ -- --gtest_filter=VeloxWriterTests.fuzzComplex --writer_tests_seed 3173165506 ``` a min chunk size of 263 and a max chunk size of 266 is selected. In the soft chunking phase, when `ensureFullChunks` is true, the stream chunker accumulates the maximum number of values with total size up to but not exceeding the max chunk size. Differential Revision: D88092017
meta-cla
bot
added
the
CLA Signed
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88092017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In
VeloxWriterTests.fuzzComplexrandom min and max stream chunk size values are selected. However, flaky errors may occur when these values are close. For instance in this case:a min chunk size of 263 and a max chunk size of 266 is selected. In the soft chunking phase, when
ensureFullChunksis true, the stream chunker accumulates the maximum number of values with total size up to but not exceeding the max chunk size.Differential Revision: D88092017