Reduce add_library() #319
Open
Reduce add_library() #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
@assignUser Could you take a look at this? |
Fix facebookincubator#298 Reduce `add_library()`s to the following 2 `add_library()`s: ```cmake add_library(nimble) add_library(nimble_test) ``` `nimble` is for Nimble features. `nimble_test` is for test. All non test files are sources of `nimble`. `nimble_test` depends on `nimble` and test related dependencies such as `gtest_main`. Each test links to `nimble_test`. Each test doesn't need to link to `gtest_main` and so on. This PR doesn't install `nimble`. I'll work on it in a separated PR.
kou
force-pushed
the
reduce-add-library
branch
from
6e9cfd9 to
77d49ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #298
Reduce
add_library()s to the following 2add_library()s:nimbleis for Nimble features.nimble_testis for test.All non test files are sources of
nimble.nimble_testdepends onnimbleand test related dependencies such asgtest_main. Each test links tonimble_test. Each test doesn't need to link togtest_mainand so on.This PR doesn't install
nimble. I'll work on it in a separated PR.