Skip to content

Conversation

@kou
Copy link
Contributor

@kou kou commented Nov 11, 2025

Fix #307

This generates nimble-${TAG}.tar.gz{,.sha256,sha512} and uploads to GitHub Release.

Example: https://github.com/kou/nimble/releases/tag/0.1.0

This also creates a GitHub Discussion automatically.

Example: kou#1

This assumes that we use ${VERSION} not v${VERSION} as tag name. I like no v prefix tag name (because v is meaningless and we need additional work to extract version from tag name) but I can change the implementation to assume v${VERSION} tag name.

nimble-${TAG}.tar.gz doesn't include velox/ submodule because I'll remove velox/ in #215.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 11, 2025
@kou
Copy link
Contributor Author

kou commented Nov 13, 2025

@assignUser Could you review this?

Copy link

@HuamengJiang HuamengJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change and the release discussion LGTM. Thanks again @kou.

Gently pinging @assignUser in case a more granular review is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare a CI job to build source archive automatically

2 participants