][be] Attach file path to VeloxExceptions thrown from DWRF reader ctor, Nimble tablet and file reader ctors #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, Nimble tablet and file reader ctors Summary: VeloxException has a mechanism to attach scope bound context to VeloxExceptions thrown out of scope. Let's leverage it to add the file path to exceptions thrown from: * DWRF batch reader constructor * Nimble tablet reader constructor * Nimble batch file reader constructor Later we can also add the file path to the reader::next method. Differential Revision: D85173751
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
VeloxException has a mechanism to attach scope bound context to VeloxExceptions thrown out of scope. Let's leverage it to add the file path to exceptions thrown from:
Later we can also add the file path to the reader::next method.
Differential Revision: D85173751