Disable MC in the compression test #264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As MacVincent discovered, the MC is getting enabled in opt mode, which changes the compression behavior. With enabled MC the minimal compression threshold for MetaInternal grows by additional 20 bytes. For now let's just disable the MC in the test to force it to the old behavior, and let's re-evaluate the MC threshold separately to see whether we should raise it to 80-100 bytes or adjust to the new MC threshold. Differential Revision: D83215102
meta-cla
bot
added
the
CLA Signed
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As MacVincent discovered, the MC is getting enabled in opt mode, which changes the compression behavior. With enabled MC the minimal compression threshold for MetaInternal grows by additional 20 bytes.
For now let's just disable the MC in the test to force it to the old behavior, and let's re-evaluate the MC threshold separately to see whether we should raise it to 80-100 bytes or adjust to the new MC threshold.
Differential Revision: D83215102