This repository was archived by the owner on Jan 13, 2022. It is now read-only.
At least one endpoint allows for the type parameter to be set in the URL... #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URL (paginated responses for example). If we're making a request to a URL with 'type' already specified, we don't need to include it as a query parameter
|
@gfosco - You asked me to rebase this against the latest, so I did. All the tests are passing But I don't think its related to change - that test was failing even before my commit. |
gfosco
added a commit
that referenced
this pull request
Sep 23, 2014
At least one endpoint allows for the type parameter to be set in the URL...
|
If this is also necessary in the 4.1 branch, I welcome a PR for that too. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... (paginated responses for example). If we're making a request to a URL with 'type' already specified, we don't need to include it as a query parameter