This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Pinning prettier to 1.9.1 and fixing travis segfault #1575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Testing to see if we still get segfaults
mitermayer
changed the title
|
@flarnie , Looks like this combination fixes our builds |
builds remain green
zpao
approved these changes
Dec 15, 2017
mitermayer
changed the title
There was a problem hiding this comment.
@mitermayer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Tonours
pushed a commit
to Tonours/draft-js
that referenced
this pull request
Dec 15, 2017
Summary: - Testing to see if we still get segfaults Closes facebookarchive#1575 Differential Revision: D6581397 fbshipit-source-id: 8c808550284ec292c9e327247e6c2f0c5ee58f2e
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: - Testing to see if we still get segfaults Closes facebookarchive/draft-js#1575 Differential Revision: D6581397 fbshipit-source-id: 8c808550284ec292c9e327247e6c2f0c5ee58f2e
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: - Testing to see if we still get segfaults Closes facebookarchive/draft-js#1575 Differential Revision: D6581397 fbshipit-source-id: 8c808550284ec292c9e327247e6c2f0c5ee58f2e
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: - Testing to see if we still get segfaults Closes facebookarchive/draft-js#1575 Differential Revision: D6581397 fbshipit-source-id: 8c808550284ec292c9e327247e6c2f0c5ee58f2e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally we are now using prettier 1.9.1.
This PR pins prettier to
1.9.1and fixes the segfault builds that were caused by running travis on old node versions