Fix right/bottom in absolute layout.

[yihuang]

1, Change bottom to be based� on height of parent.
2, Respect margin value when layout with right/bottom.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

[woehrl01]

@yihuang It would be great if you could add a test for this change. You simply have to add a html layout inside the fixture folder and run gentest.rb.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[yihuang]

@woehrl01 When I run ruby gentest.rb, i got error, i'm running with ruby 2.4.1:

/usr/local/lib/ruby/gems/2.4.0/gems/watir-webdriver-0.9.9/lib/watir-webdriver/elements/table_cell.rb:3:in `alias_method': undefined method `col_span' for class `Watir::TableCell' (NameError)
	from /usr/local/lib/ruby/gems/2.4.0/gems/watir-webdriver-0.9.9/lib/watir-webdriver/elements/table_cell.rb:3:in `<class:TableCell>'
	from /usr/local/lib/ruby/gems/2.4.0/gems/watir-webdriver-0.9.9/lib/watir-webdriver/elements/table_cell.rb:2:in `<module:Watir>'
	from /usr/local/lib/ruby/gems/2.4.0/gems/watir-webdriver-0.9.9/lib/watir-webdriver/elements/table_cell.rb:1:in `<top (required)>'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/lib/ruby/gems/2.4.0/gems/watir-webdriver-0.9.9/lib/watir-webdriver.rb:119:in `<top (required)>'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in `require'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in `rescue in require'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from gentest.rb:3:in `<main>'

[woehrl01]

@yihuang looks like an incompatibility with ruby 2.4.*. see watir/watir#508. I use ruby 2.2.1 locally. Maybe @emilsjolander know more about this?

[emilsjolander]

Looks line the issue is closed. Maybe we can just upgrade our watir dep?

[emilsjolander]

@yihuang Try running with ruby 2.2. I agree with @woehrl01 we want a test to ensure we don't regress this in the future.

[yihuang]

@woehrl01 tests has been added.

[woehrl01]

Thank you @yihuang!
As travis fails I verified the tests locally, looks good to me @emilsjolander.

[facebook-github-bot]

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.