Fix align-content:strech overriding align-item #417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilsjolander
approved these changes
Feb 22, 2017
| </div> | ||
|
|
||
| <div id="align_content_stretch_is_not_overriding_align_items" style="align-content:stretch;"> | ||
| <div style="width:100px; height: 100px; align-items: center; flex-direction: row; align-content:stretch;"> |
Contributor
There was a problem hiding this comment.
please use spaces instead of tabs 👍
Contributor
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 23, 2017
Summary: Fix for #413. This was a hangover from a previous attept to fix other align-content problems. Closes facebook/yoga#417 Reviewed By: astreet Differential Revision: D4604727 Pulled By: emilsjolander fbshipit-source-id: 92fd31a385d8182c6b201c891d5ae478372d525d
GaborWnuk
pushed a commit
to GaborWnuk/react-native
that referenced
this pull request
Feb 28, 2017
Summary: Fix for facebook#413. This was a hangover from a previous attept to fix other align-content problems. Closes facebook/yoga#417 Reviewed By: astreet Differential Revision: D4604727 Pulled By: emilsjolander fbshipit-source-id: 92fd31a385d8182c6b201c891d5ae478372d525d
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: Fix for facebook#413. This was a hangover from a previous attept to fix other align-content problems. Closes facebook/yoga#417 Reviewed By: astreet Differential Revision: D4604727 Pulled By: emilsjolander fbshipit-source-id: 92fd31a385d8182c6b201c891d5ae478372d525d
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: Fix for facebook#413. This was a hangover from a previous attept to fix other align-content problems. Closes facebook/yoga#417 Reviewed By: astreet Differential Revision: D4604727 Pulled By: emilsjolander fbshipit-source-id: 92fd31a385d8182c6b201c891d5ae478372d525d
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: Fix for #413. This was a hangover from a previous attept to fix other align-content problems. Closes facebook/yoga#417 Reviewed By: astreet Differential Revision: D4604727 Pulled By: emilsjolander fbshipit-source-id: 92fd31a385d8182c6b201c891d5ae478372d525d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #413. This was a hangover from a previous attept to fix other align-content problems.