Fix percentage in flexing parent #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilsjolander
approved these changes
Feb 22, 2017
Contributor
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
astreet
reviewed
Feb 23, 2017
yoga/Yoga.c
Outdated
| childCrossMeasureMode = | ||
| YGFloatIsUndefined(childCrossSize) ? YGMeasureModeUndefined : YGMeasureModeExactly; | ||
| YGFloatIsUndefined(childCrossSize) || | ||
| (currentRelativeChild->resolvedDimensions[dim[crossAxis]]->unit == |
Contributor
There was a problem hiding this comment.
Could we extract this condition into a named bool? Or add comments on the two conditions we're trying to check here?
Contributor
|
@woehrl01 I think you accidentally added a bunch of |
woehrl01
force-pushed
the
percentage-flex
branch
from
fc09590 to
86fd730
Compare
Contributor
Author
|
@emilsjolander ups, sorry! here you are! 😄 |
Contributor
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: If we don't measure exactly, percentage values aren't exactly either. Fix for facebook#414. Closes facebook/yoga#416 Closes facebook/yoga#414 Reviewed By: astreet Differential Revision: D4604729 Pulled By: emilsjolander fbshipit-source-id: 66880230073209cbe89668b838c2a82e7f9b34df
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: If we don't measure exactly, percentage values aren't exactly either. Fix for facebook#414. Closes facebook/yoga#416 Closes facebook/yoga#414 Reviewed By: astreet Differential Revision: D4604729 Pulled By: emilsjolander fbshipit-source-id: 66880230073209cbe89668b838c2a82e7f9b34df
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: If we don't measure exactly, percentage values aren't exactly either. Fix for #414. Closes facebook/yoga#416 Closes facebook/yoga#414 Reviewed By: astreet Differential Revision: D4604729 Pulled By: emilsjolander fbshipit-source-id: 66880230073209cbe89668b838c2a82e7f9b34df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't measure exactly, percentage values aren't exactly either. Fix for #414.