Carthage and CocoaPods support #309
Conversation
YogaKit/YogaKit.podspec
Outdated
| spec.homepage = 'https://facebook.github.io/yoga/' | ||
| spec.authors = { | ||
| 'Emil Sjölander' => '[email protected]', | ||
| 'Dustin Shahidehpour' => '[email protected]' |
| 'Emil Sjölander' => '[email protected]', | ||
| 'Dustin Shahidehpour' => '[email protected]' | ||
| } | ||
| spec.summary = 'Yoga is a cross-platform layout engine which implements Flexbox.' |
There was a problem hiding this comment.
YogaKit is a view layout library which is powered by Yoga, a layout engine which implements Flexbox.
There was a problem hiding this comment.
I've copied pasted that description from the one that appears in Yoga's GitHub repository. Should I change it anyways?
|
|
||
| @property (strong, nonatomic) UIWindow *window; | ||
|
|
||
|
|
| * LICENSE-examples file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #import "AppDelegate.h" |
There was a problem hiding this comment.
Do we have to regenerate this? Let's revert this.
|
@dshahidehpour You made some comments in files that are originally part of @hartbit PR, #305 . For some reason I could not make |
|
@guidomb but as you improved on my PR, wouldn't it be better to rename this PR Cocoapods + Carthage support and fix everything here? |
|
@hartbit If you agree with that, sure. In that case I would suggest closing the other PR and focus on trying to fix the buck build and the comments suggested by @dshahidehpour here. |
guidomb
changed the title
|
@guidomb Any update on this? The changes to add swift support have landed, so, you probably won't run into as many (if any) rebase problems. |
|
@dshahidehpour Sorry, I've been on vacations the last week. Cool that #322 has been merged!!! I'll try to get this working tomorrow. I'll let you know if I had any issues. Have you defined a version number that should be used in the CocoaPods podspec file? |
|
@guidomb No defined a version yet. I'll do that tomorrow! Thanks for reminding me. Will most likely be version |
|
OK, I was about to start working on it. I'll subscribe to #328 and get back to this once that one is merged. Thanks for letting me know! |
|
@guidomb #328 is going to be closed momentarily, any chance we could start on this again? @emilsjolander can help with the versioning :) |
|
I'll try to work on this tomorrow. Will #328 be merged into |
|
yeahp! |
|
I've made a new PR to address this -> #352 |
Summary: This supersedes #309 and #305. This is still a **work-in-progress.** **TODO** - [x] Create Xcode project that builds an iOS framework - [x] Fix failing tests on Xcode - [ ] Make `pod lib lint` pass and make sure YogaKit can be included using CocoaPods - [ ] Add `pod lib lint` to .travis.yml - [x] Migrate to travis osx image with Xcode 8.2 **FOLLOW-UP** - [ ] Make YogaKitSample use framework built by new Xcode project. - [ ] Make Travis to upload prebuilt versions of the framework. More [here](https://github.com/Carthage/Carthage#use-travis-ci-to-upload-your-tagged-prebuild-frameworks) - [ ] Upgrade github/jekyll docs about installation using Cocoapods/Carthage Closes #352 Reviewed By: emilsjolander Differential Revision: D4471950 Pulled By: dshahidehpour fbshipit-source-id: 8f30c69f9a487b26aa2e5f3b66841334b01b0ab1
5 participants
This is first attempt to add support for CocoaPods. It is currently not working because CocoaPods requires a valid semver number (and a corresponding git tag) as the library version.
This is based on #305 and should be merged after that PR is merged.
@emilsjolander @dshahidehpour Please check if the author information in the
YogaKit.podspecfile is correct.Once this PR is merged in order for people to actually be able to install this using CocoaPods, the pod must be published to CocoaPods' trunk. Which requires to have an account. For more information check https://guides.cocoapods.org/making/getting-setup-with-trunk.html.
Also keep in mind that every time you make a new release you need to update the
versionproperty insideYogaKit.podspecand publish a new version to trunk.