Make sure indentation is tracked #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
amyreese
approved these changes
Jul 29, 2022
Collaborator
amyreese
left a comment
amyreese
left a comment
There was a problem hiding this comment.
Other than the changelog change, looks good to me.
CHANGELOG.md
Outdated
| $ git shortlog -sn v1.0.1... | ||
| 7 dependabot[bot] | ||
| 5 John Reese | ||
| 5 John Reesemk |
Contributor
Author
There was a problem hiding this comment.
mk is definitely not my password anywhere 👀
zsol
force-pushed
the
fix-indentation-tracking
branch
from
f565769 to
ce0aa88
Compare
zsol
force-pushed
the
fix-indentation-tracking
branch
from
ce0aa88 to
dd1bb07
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187 broke the logic that keeps track of indentation for the purposes of line length tracking by not letting
visit_IndentedBlockrun in the transformer.This affected (import) lines that are long enough to fit
line_lengthwithout the indentation, but too long if we count indentation too.This PR adds a test case for this situation.