Disable persisted queries in validate mode

[aryaniyaps]

Right now, when the CLI is run in valdiate mode with persisted queries enabled, the compiler fails with connection refused errors (when the persisting server is not available).

This issue is most evident in CI pipelines when generally the persisting server won't be available.

Example error message:

➜  accounts (main) relay-compiler --validate                                                                                                                                                                                                                      ✭
[INFO] Querying files to compile...
[INFO] [default] compiling...
[ERROR] Error: Network error: error trying to connect: tcp connect error: Connection refused (os error 111)
[ERROR] Compilation failed.
[ERROR] Unable to run relay compiler. Error details: 
Failed to build:
 - Persisting operation(s) failed:
 - Network error: error trying to connect: tcp connect error: Connection refused (os error 111)

But the expected behaviour is that the query persister must be disabled in validate mode.

This PR attempts to fix that.

Issue(s) closed: #5007

[facebook-github-bot]

Hi @aryaniyaps!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[evanyeung]

Thanks for the PR @aryaniyaps! Are you able to revert the changes to the unrelated files that look mostly like formatting? It will make internal review easier.

[aryaniyaps]

@evanyeung I've done that! Must have been some extension locally that auto formatted the files!

[evanyeung]

Thanks for updating! It looks like there's still one file with unexpected formatting changes (graphqlschema_generated.rs)

[aryaniyaps]

@evanyeung I'm sorry! I missed that! I've reverted formatting changes now!

[facebook-github-bot]

@evanyeung has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@evanyeung has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@evanyeung merged this pull request in ff27db4.