-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add missing generic type parameter for mutation tutorial example #4981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! This looks great. Do you mind also updating the v19 docs as well? https://github.com/facebook/relay/blob/main/website/versioned_docs/version-v19.0.0/tutorial/mutations-updates.md |
Of course, will do now! |
Done, please let me know if we need anything else :) @captbaritone |
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
btw it would be great to merge this together with relayjs/relay-examples#333, I have tested the example with this change and it works great :) |
@captbaritone merged this pull request in f25a9d1. |
CleanShot_2025-05-07_at_23.13.43.mp4I noticed something weird. On fresh load, typescript LSP complains about this typing here, but if I remove the code and add the same code back, it does not complain anymore 🤔 Edit: I think I found a fix, will raise a PR soon |
https://relay.dev/docs/tutorial/mutations-updates/#step-4--modify-the-updatable-data
This step of the tutorial is currently giving us type errors.
This is because we are missing the generic type parameter.
Note that this will also require us to upstream the relay dependencies in the example to the latest v19: relayjs/relay-examples#333
After that, our tutorial will be working properly with no type error!