Fix observeFragment triggering unhandled rejections on network error

[XiNiHa]

This PR fixes an issue where observeFragment triggers unhandled rejections on network error, which happens because of the dangling promise created and dropped.

[captbaritone]

Thanks for the PR. Is it possible to construct a regression test?

[XiNiHa]

Thanks for the PR. Is it possible to construct a regression test?

You can now switch to 4e2c53a and see the test failing :)

btw, while working on the test, I realized that the current behavior is somewhat unnatural since it doesn't notify the observer at all when network errors occur. While I also think that it's inappropriate to return network errors from fragment observation, I believe it should fallback to returning missing data at least 🤔

[captbaritone]

Good catch that we don't model query errors as fragment errors. Given that's existing behavior, maybe we can tackle that as a second PR. Mind opening an issue?

[facebook-github-bot]

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[XiNiHa]

Good catch that we don't model query errors as fragment errors. Given that's existing behavior, maybe we can tackle that as a second PR. Mind opening an issue?

#4888 ✅

[captbaritone]

I've run into an issue merging this due to subtle differences in how Jest works internally vs here in open source. I'm working to resolve that issue.

[facebook-github-bot]

@captbaritone merged this pull request in 10073c8.