Fix conditional sub-selections in raw response type #4774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
2 times, most recently
from
3424c75 to
a2f2295
Compare
|
The test failure in the ubuntu job seems to be unrelated / transient, but I can't trigger another run. EDIT: This also happens on main, so it's not the fault of my changes. |
...s/relay-typegen/tests/generate_flow/fixtures/query-with-raw-response-on-conditional.expected
Show resolved
Hide resolved
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
from
a2f2295 to
cde4f43
Compare
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
from
cde4f43 to
dcd36ad
Compare
|
@captbaritone Fixed the merge conflicts on this one. |
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
2 times, most recently
from
ef5d660 to
7f56dfe
Compare
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
from
7f56dfe to
eb6bc69
Compare
|
@captbaritone could this be merged? Same goes for #4775 |
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
from
eb6bc69 to
11a6820
Compare
tobias-tengler
force-pushed
the
fix-raw-response-type-conditional-sub-selections
branch
from
11a6820 to
7e86478
Compare
|
@captbaritone Could we land this? |
|
@captbaritone merged this pull request in 38ae469. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously conditional selections were always generated as required properties on the raw response type.
This is inconvenient if your component code checks for the presence of a field and you can't model the skipped state in a test using
@raw_response_typewithout partially disabling type checking.This PR makes all conditional selections optional in the raw response type.