Skip to content

Conversation

eMerzh
Copy link
Contributor

@eMerzh eMerzh commented Jan 23, 2024

since 4e68155d732b the custom scalar config has changed,
so let's update the doc

@facebook-github-bot
Copy link
Contributor

@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@monicatang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tobias-tengler
Copy link
Contributor

tobias-tengler commented Jan 23, 2024

@alunyov Maybe it would also be helpful to update the Release notes with the new name in camelCase customScalarTypes. In my PR I only mentioned the Rust variable names, but for the developer those fields are customScalars and customScalarTypes and not custom_scalars and custom_scalar_types.

@alunyov
Copy link
Contributor

alunyov commented Jan 23, 2024

@alunyov Maybe it would also be helpful to update the Release notes with the new name in camelCase customScalarTypes. In my PR I only mentioned the Rust variable names, but for the developer those fields are customScalars and customScalarTypes and not custom_scalars and custom_scalar_types.

Done!

@facebook-github-bot
Copy link
Contributor

@monicatang merged this pull request in 615c2d2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants