Add CircleCI support to 15-stable #8778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Yarn (facebook#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm
* Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile
Nothing really changes.
D4329549
gaearon
reviewed
Jan 13, 2017
| @@ -66,11 +68,11 @@ var DOMRenderer = ReactFiberReconciler({ | |||
| return true; | |||
| }, | |||
|
|
|||
| commitUpdate(domElement : Instance, oldProps : Props, newProps : Props, children : HostChildren<Instance>) : void { | |||
| domElement.innerHTML = ''; | |||
| recursivelyAppendChildren(domElement, children); | |||
There was a problem hiding this comment.
Can you avoid this change?
It's a bit messy because the histories diverged.
I only changed this method here because Flow complained at domElement.textContent = newProps.children; assignment. However in 15-stable this code didn't exist in the first place so we can safely leave the old implementation here.
|
Looks great. Now that I think of it, I wonder if we should have done this against Any chance you could look into what it would take to submit this PR against |
|
Going to get this in and cherry-pick to |
gaearon
pushed a commit
that referenced
this pull request
Jan 23, 2017
* devDependencies: add core-js and es6-symbol polyfill for tests * Update Flow and fix issues (#8006) * Add npm v4.0.0 support (#8082) * Add support for node v7 (#8135) * Upgrade ESLint and dependencies, fix new lint errors, switch Travis to Yarn (#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm * Update all Jest packages to 17.x (#8327) * Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile * Update Flow to 0.37.0 (#8608) Nothing really changes. * Update to Jest 18 (#8621) * mockImpl -> mockImplementation D4329549 * Fixed linting errors * circle.yml and circleci scripts * Update Flow and fix issues (#8006) * Fixed flow errors * Updated shrinkwrap * Removed unnecessary change * Added jest --runInBand flag * Removed ReactDOMFiber changes
|
It worked! That was awesome. Thank you so much, it's a very meaningful contribution. Usually people don't like tasks like this but it's super useful when somebody can help out. |
|
No problem! Thanks for your help along the way. I'm glad I could help out and learn more about the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at fixing #8744 after better understanding the problem space.
I cherry-picked commits to
package.jsonto bring it closer tomasterand then added thecircle.ymlandscripts/circlecichanges needed to run CircleCI.