Skip to content

[Fiber] Update refs even if shouldComponentUpdate returns false #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2017
Merged

[Fiber] Update refs even if shouldComponentUpdate returns false #8685

merged 1 commit into from
Jan 4, 2017

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 4, 2017

Implemented using a Ref effect type.

@acdlite
Update refs even if shouldComponentUpdate returns false
2517a11 
Implemented using a Ref effect type.
@sebmarkbage sebmarkbage mentioned this pull request Jan 4, 2017
Closed
bvaughn
bvaughn approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

@acdlite acdlite merged commit 39278c4 into facebook:master Jan 4, 2017
@sebmarkbage sebmarkbage mentioned this pull request Jan 11, 2017
Merged
bvaughn added a commit that referenced this pull request Jan 13, 2017
@bvaughn
Replaced an Update effect in complete phase with a Ref effect
7817eb0 
Also removed an unnecessary conditional check and improved a flow cast.

Relates originally to PRs #8646 and #8685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@gaearon gaearon Awaiting requested review from gaearon

1 more reviewer

@bvaughn bvaughn bvaughn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @bvaughn @facebook-github-bot