[WIP][Fiber] Make Fiber a disjoint union based on the tag #8545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes one type for each type of Fiber work. Fiber is the union of them all. We currently can't use intersection types to avoid duplicating type defs. We'll have to wait for the new spread feature in Flow to do that. So instead I added a manually exploded version in FiberTypes.exploded.
Fix this before landing.
Merged
|
Closing as stale. Nice try tho. |
|
Filed as #11101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us type things more precisely. I've already found a few issues around refs.
Unfortunately, this currently causes an infinite loop in Flow so we can't land it.
It's also far from complete. More work is needed.