Skip to content

Process childContextTypes via internal constructor#3940

Merged
sebmarkbage merged 1 commit intofacebook:masterfrom
troutowicz:context_processing
Jun 4, 2015
Merged

Process childContextTypes via internal constructor#3940
sebmarkbage merged 1 commit intofacebook:masterfrom
troutowicz:context_processing

Conversation

@troutowicz
Copy link
Copy Markdown
Contributor

Allow factory based components, created with libraries like Stampit, to use child context.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ericelliott
Copy link
Copy Markdown
Contributor

👍

@troutowicz
Copy link
Copy Markdown
Contributor Author

@sebmarkbage @zpao

Any update on getting this merged? The same reasoning applies here as in #3941

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary because the wrappers are getting removed in another PR. Also, no wrapper should need to use child context.

@sebmarkbage
Copy link
Copy Markdown
Contributor

lgtm

sebmarkbage added a commit that referenced this pull request Jun 4, 2015
Process childContextTypes via internal constructor
@sebmarkbage sebmarkbage merged commit 2d9a084 into facebook:master Jun 4, 2015
@gavriguy
Copy link
Copy Markdown

gavriguy commented Sep 8, 2015

👍

@troutowicz troutowicz deleted the context_processing branch July 30, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants