[DevTools] Layout for Suspense tab #34042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Jul 29, 2025
| @@ -46,8 +52,10 @@ type Props = { | |||
| type: IconType, | |||
| }; | |||
|
|
|||
| const materialIconsViewBox = '0 -960 960 960'; | |||
There was a problem hiding this comment.
It's just the default https://fonts.google.com/icons comes with. You can scale the paths to adhere to the default viewbox but I couldn't find a tool for that quickly and none of the LLMs produced a result I could use.
The Material icons are the ones Chrome is using for the sidebar toggles.
They're license under Apache 2: https://developers.google.com/fonts/docs/material_icons#licensing
eps1lon
force-pushed
the
sebbie/suspensetabui
branch
from
4f56a25 to
2f33673
Compare
eps1lon
commented
Jul 29, 2025
| element.releasePointerCapture(event.pointerId); | ||
| }; | ||
|
|
||
| const onResizeTree = (event: SyntheticPointerEvent<HTMLElement>) => { |
There was a problem hiding this comment.
There's probably an abstraction here that can be shared with the Components tab. I had to slightly adjust where and what percentage values with set though so I opted for duplicating. At least during experimentation phase.
sebmarkbage
approved these changes
Jul 29, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 2, 2025
DiffTrain build for [36c63d4](facebook@36c63d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Components tab UI but with an additional column on the left.
With the additional left column it got a bit more crowded so I'm using the same layout Chrome's Sources panel uses: Navigator (here: tree list) and content (here: rects) are always two columns. Debugger (here: inspected element) is the rightmost column if enough horizontal space is available. Otherwise it gets pushed below navigator/content.
Icons and borders aren't aligned yet. I'll adjust those once these panes actually get content. I just needed something that allows me to easily make room for the pane I'm currently focusing on. Might move the toggle icons to the rects pane since timeline pane has very little space to deal with.
CleanShot.2025-07-29.at.19.07.12.mp4