Skip to content

Remove feature flag enableRenderableContext #33505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 11, 2025

The flag is fully rolled out.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 11, 2025
@kassens kassens requested a review from rickhanlonii June 11, 2025 15:36
@react-sizebot
Copy link

react-sizebot commented Jun 11, 2025

Comparing: 56408a5...3228a86

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.58 kB 530.49 kB = 93.66 kB 93.64 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.67 kB 651.58 kB = 114.77 kB 114.76 kB
facebook-www/ReactDOM-prod.classic.js = 676.61 kB 675.01 kB = 119.05 kB 118.81 kB
facebook-www/ReactDOM-prod.modern.js = 666.89 kB 665.48 kB = 117.44 kB 117.23 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 13.37 kB 12.90 kB = 3.60 kB 3.52 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 13.37 kB 12.90 kB = 3.60 kB 3.52 kB
facebook-www/React-dev.classic.js = 56.15 kB 54.05 kB = 12.31 kB 12.05 kB
facebook-www/React-dev.modern.js = 56.14 kB 54.05 kB = 12.31 kB 12.05 kB
facebook-www/ReactIs-dev.classic.js = 6.49 kB 5.79 kB = 1.40 kB 1.31 kB
facebook-www/ReactIs-dev.modern.js = 6.49 kB 5.79 kB = 1.40 kB 1.31 kB
facebook-www/ReactIs-prod.classic.js = 5.89 kB 5.24 kB = 1.37 kB 1.27 kB
facebook-www/ReactIs-prod.modern.js = 5.89 kB 5.24 kB = 1.37 kB 1.27 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js +0.99% 248.38 kB 250.84 kB +0.61% 44.65 kB 44.92 kB
facebook-www/ReactDOMTesting-prod.modern.js = 681.30 kB 679.88 kB = 121.07 kB 120.87 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 260.47 kB 259.93 kB = 47.67 kB 47.57 kB
facebook-www/ReactDOM-prod.modern.js = 666.89 kB 665.48 kB = 117.44 kB 117.23 kB
facebook-www/ReactDOM-profiling.classic.js = 746.88 kB 745.27 kB = 128.41 kB 128.17 kB
facebook-www/ReactDOM-profiling.modern.js = 738.83 kB 737.23 kB = 127.12 kB 126.87 kB
facebook-www/ReactReconciler-dev.classic.js = 849.98 kB 848.06 kB = 131.97 kB 131.70 kB
facebook-www/ReactReconciler-dev.modern.js = 840.78 kB 838.86 kB = 130.21 kB 129.94 kB
facebook-www/ReactDOMTesting-prod.classic.js = 691.02 kB 689.41 kB = 122.63 kB 122.40 kB
facebook-www/ReactDOM-prod.classic.js = 676.61 kB 675.01 kB = 119.05 kB 118.81 kB
facebook-www/ReactDOMServer-prod.classic.js = 253.82 kB 253.20 kB = 45.38 kB 45.25 kB
facebook-www/ReactART-dev.classic.js = 733.46 kB 731.56 kB = 114.15 kB 113.90 kB
facebook-www/ReactART-dev.modern.js = 723.96 kB 722.06 kB = 112.39 kB 112.16 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js = 13.24 kB 13.20 kB = 3.48 kB 3.47 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 13.23 kB 13.20 kB = 3.48 kB 3.47 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js = 13.09 kB 13.05 kB = 3.44 kB 3.43 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js = 13.09 kB 13.05 kB = 3.44 kB 3.43 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js = 13.09 kB 13.05 kB = 3.44 kB 3.43 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js = 13.09 kB 13.05 kB = 3.44 kB 3.43 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 12.47 kB 12.43 kB = 3.35 kB 3.34 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 12.39 kB 12.35 kB = 3.34 kB 3.34 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 12.24 kB 12.21 kB = 3.30 kB 3.29 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 12.24 kB 12.21 kB = 3.30 kB 3.29 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 12.07 kB 12.03 kB = 3.33 kB 3.32 kB
facebook-www/ReactReconciler-prod.modern.js = 500.87 kB 499.37 kB = 79.92 kB 79.73 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 11.99 kB 11.96 kB = 3.33 kB 3.32 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 11.84 kB 11.81 kB = 3.29 kB 3.28 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 11.84 kB 11.81 kB = 3.29 kB 3.28 kB
facebook-www/ReactReconciler-prod.classic.js = 511.18 kB 509.48 kB = 81.52 kB 81.26 kB
facebook-www/ReactART-prod.modern.js = 378.10 kB 376.68 kB = 63.34 kB 63.16 kB
facebook-www/ReactART-prod.classic.js = 388.09 kB 386.48 kB = 64.99 kB 64.78 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.68 kB 4.65 kB = 1.15 kB 1.14 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.68 kB 4.65 kB = 1.15 kB 1.14 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 5.21 kB 5.17 kB = 1.18 kB 1.17 kB
oss-experimental/react-is/cjs/react-is.production.js = 4.52 kB 4.49 kB = 1.09 kB 1.07 kB
oss-experimental/react-is/cjs/react-is.development.js = 5.06 kB 5.03 kB = 1.13 kB 1.13 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 4.47 kB 4.44 kB = 1.08 kB 1.07 kB
oss-stable/react-is/cjs/react-is.production.js = 4.47 kB 4.44 kB = 1.08 kB 1.07 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 5.02 kB 4.98 kB = 1.13 kB 1.12 kB
oss-stable/react-is/cjs/react-is.development.js = 5.02 kB 4.98 kB = 1.13 kB 1.12 kB
facebook-www/React-profiling.classic.js = 21.45 kB 21.11 kB = 5.45 kB 5.39 kB
facebook-www/React-profiling.modern.js = 21.45 kB 21.11 kB = 5.45 kB 5.39 kB
facebook-www/React-prod.classic.js = 21.01 kB 20.68 kB = 5.36 kB 5.31 kB
facebook-www/React-prod.modern.js = 21.01 kB 20.67 kB = 5.36 kB 5.31 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 13.37 kB 12.90 kB = 3.60 kB 3.52 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 13.37 kB 12.90 kB = 3.60 kB 3.52 kB
facebook-www/React-dev.classic.js = 56.15 kB 54.05 kB = 12.31 kB 12.05 kB
facebook-www/React-dev.modern.js = 56.14 kB 54.05 kB = 12.31 kB 12.05 kB
facebook-www/ReactIs-dev.classic.js = 6.49 kB 5.79 kB = 1.40 kB 1.31 kB
facebook-www/ReactIs-dev.modern.js = 6.49 kB 5.79 kB = 1.40 kB 1.31 kB
facebook-www/ReactIs-prod.classic.js = 5.89 kB 5.24 kB = 1.37 kB 1.27 kB
facebook-www/ReactIs-prod.modern.js = 5.89 kB 5.24 kB = 1.37 kB 1.27 kB

Generated by 🚫 dangerJS against 3228a86

The flag is fully rolled out.
@@ -87,6 +85,9 @@ const encodedStringCache: LRUCache<string, Array<number>> = new LRU({
max: 1000,
});

// Previously, the type of `Context.Provider`.
const LEGACY_REACT_PROVIDER_TYPE: symbol = Symbol.for('react.provider');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you have another way to deal with devtools needing to support older React runtimes? I just moved the otherwise deleted constant here…

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yah

@kassens kassens merged commit 6c86e56 into facebook:main Jun 11, 2025
245 checks passed
@kassens kassens deleted the pr33505 branch June 11, 2025 15:53
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
The flag is fully rolled out.

DiffTrain build for [6c86e56](6c86e56)
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
The flag is fully rolled out.

DiffTrain build for [6c86e56](6c86e56)
hoxyq added a commit that referenced this pull request Jun 27, 2025
Full list of changes:

* devtools: emit performance entries only when profiling
([hoxyq](https://github.com/hoxyq) in
[#33652](#33652))
* Get Server Component Function Location for Parent Stacks using Child's
Owner Stack ([sebmarkbage](https://github.com/sebmarkbage) in
[#33629](#33629))
* Added minimum indent size to Component Tree
([jsdf](https://github.com/jsdf) in
[#33517](#33517))
* [devtools-shell] layout options for testing
([jsdf](https://github.com/jsdf) in
[#33516](#33516))
* Remove feature flag enableRenderableContext
([kassens](https://github.com/kassens) in
[#33505](#33505))
* refactor[devtools]: update css for settings and support css variables
in shadow dom scnenario ([hoxyq](https://github.com/hoxyq) in
[#33487](#33487))
* [mcp] Add MCP tool to print out the component tree of the currently
open React App ([jorge-cab](https://github.com/jorge-cab) in
[#33305](#33305))
* [scripts] Switch back to flow parser for prettier
([rickhanlonii](https://github.com/rickhanlonii) in
[#33414](#33414))
* upgrade json5 ([rickhanlonii](https://github.com/rickhanlonii) in
[#33358](#33358))
* Get source location from structured callsites in prepareStackTrace
([sebmarkbage](https://github.com/sebmarkbage) in
[#33143](#33143))
* Clean up enableSiblingPrerendering flag
([jackpope](https://github.com/jackpope) in
[#32319](#32319))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants