[Flight] Use Web Streams APIs for 3rd-party component in Flight fixture #33481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
changed the title
github-actions
bot
added
the
React Core Team
unstubbable
force-pushed
the
flight-fixture-web-streams
branch
from
dbd6628 to
7401385
Compare
|
Comparing: e4b88ae...b0e511c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jun 7, 2025
Now that the Node bundles for Webpack also expose the Web Streams APIs, we can can use those in the Flight fixture for caching the 3rd-party component, without needing to convert the streams back and forth. This new approach of how we're exposing those APIs also allows us to mix and match them with the Node Streams APIs (e.g. in the outer rendering in `fixtures/flight/server/region.js`). This was not possibly with the previous approach of using separate bundles, because React only allows a single RSC renderer to be active at a time.
unstubbable
force-pushed
the
flight-fixture-web-streams
branch
from
7401385 to
b0e511c
Compare
This was referenced Jun 9, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33480.
Now that the Node bundles for Webpack also expose the Web Streams APIs, we can can use those in the Flight fixture for caching the 3rd-party component, without needing to convert the streams back and forth.
This new approach of how we're exposing those APIs also allows us to mix and match them with the Node Streams APIs (e.g. in the outer rendering in
fixtures/flight/server/region.js). This was not possible with the previous approach of using separate bundles, because React only allows a single RSC renderer to be active at a time.