[react-native] Pull up enableFastAddPropertiesInDiffing check #33043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: c498bfc...45e125e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rubennorte
approved these changes
Apr 28, 2025
Yup. Validated that when I broke this method in the experiment path, tests would fail. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary We don't need the isArray check for this experiment, as `fastAddProperties` already does the same. Also renaming slowAddProperties to make it clearer we can fully remove this codepath once fastAddProperties is fully rolled out. ## How did you test this change? ``` yarn test packages/react-native-renderer -r=xplat --variant=true ``` DiffTrain build for [0038c50](0038c50)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Apr 29, 2025
…ok#33043) ## Summary We don't need the isArray check for this experiment, as `fastAddProperties` already does the same. Also renaming slowAddProperties to make it clearer we can fully remove this codepath once fastAddProperties is fully rolled out. ## How did you test this change? ``` yarn test packages/react-native-renderer -r=xplat --variant=true ``` DiffTrain build for [0038c50](facebook@0038c50)
This was referenced Apr 29, 2025
This was referenced May 5, 2025
This was referenced May 12, 2025
This was referenced May 19, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't need the isArray check for this experiment, as
fastAddPropertiesalready does the same. Also renaming slowAddProperties to make it clearer we can fully remove this codepath once fastAddProperties is fully rolled out.How did you test this change?