compiler: Scope-based reordering #29803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends instruction reordering further to allow reordering of instructions in different scopes. The basic idea is that each instructions within a scope maintain their original order with respect to each other, but instructions for different scopes can be reordered relative to other scopes. This allows interleaved or nested scopes to be reordered to avoid the interleaving/nesting. There are lot of things still very broken about this, but the one new fixture shows an example of this working. Note that this approach works very well for interleaving. We'll probably need to add a bit more to handle nesting - in general it's better to move nested scopes first before their parent scope, but the current algorithm for reordering doesn't take this into account yet. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 7, 2024
josephsavona
added a commit
that referenced
this pull request
Jun 7, 2024
Extends instruction reordering further to allow reordering of instructions in different scopes. The basic idea is that each instructions within a scope maintain their original order with respect to each other, but instructions for different scopes can be reordered relative to other scopes. This allows interleaved or nested scopes to be reordered to avoid the interleaving/nesting. There are lot of things still very broken about this, but the one new fixture shows an example of this working. Note that this approach works very well for interleaving. We'll probably need to add a bit more to handle nesting - in general it's better to move nested scopes first before their parent scope, but the current algorithm for reordering doesn't take this into account yet. ghstack-source-id: 9dc8e62 Pull Request resolved: #29803
facebook-github-bot
added
the
React Core Team
|
Comparing: c4b433f...86b0af8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Extends instruction reordering further to allow reordering of instructions in different scopes. The basic idea is that each instructions within a scope maintain their original order with respect to each other, but instructions for different scopes can be reordered relative to other scopes. This allows interleaved or nested scopes to be reordered to avoid the interleaving/nesting.
There are lot of things still very broken about this, but the one new fixture shows an example of this working.
Note that this approach works very well for interleaving. We'll probably need to add a bit more to handle nesting - in general it's better to move nested scopes first before their parent scope, but the current algorithm for reordering doesn't take this into account yet.