Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 22, 2024

#28407 was based on a state before #28515 and #28509 so it missed the cleanups in those PRs.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 22, 2024
@react-sizebot
Copy link

Comparing: 5b903cd...763da97

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 497.54 kB 497.54 kB = 88.93 kB 88.93 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 502.86 kB 502.86 kB = 89.84 kB 89.84 kB
facebook-www/ReactDOM-prod.classic.js = 591.00 kB 591.00 kB = 103.95 kB 103.95 kB
facebook-www/ReactDOM-prod.modern.js = 566.82 kB 566.82 kB = 100.15 kB 100.15 kB
test_utils/ReactAllWarnings.js Deleted 64.68 kB 0.00 kB Deleted 16.15 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.68 kB 0.00 kB Deleted 16.15 kB 0.00 kB

Generated by 🚫 dangerJS against 763da97

@eps1lon eps1lon requested a review from jackpope April 22, 2024 14:01
@eps1lon eps1lon merged commit 699d03c into facebook:main Apr 22, 2024
@eps1lon eps1lon deleted the cleanup-replayFailedUnitOfWorkWithInvokeGuardedCallback branch April 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants